Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification to paramter el #50

Open
ppazos opened this issue Oct 10, 2021 · 1 comment
Open

Clarification to paramter el #50

ppazos opened this issue Oct 10, 2021 · 1 comment

Comments

@ppazos
Copy link

ppazos commented Oct 10, 2021

Current README has:

el (optional, string, Element) - this parameter is optional but if no selector or element is passed it defaults to body.

This doesn't specify that the el selector or element is the container of the DOM generated by the picker.

For instance, I have specified the selector as a class of an input field and that doesn't work, it should be a container element like a div, which is not clear in the current spec.

@priyank-p
Copy link
Owner

Can you do a please quick PR clarifying that if possible? I won't be able to get to it until next weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants