Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(watch): log reason for rerun & improved exit handling #412

Merged
merged 8 commits into from
Nov 24, 2023
Merged

feat(watch): log reason for rerun & improved exit handling #412

merged 8 commits into from
Nov 24, 2023

Conversation

privatenumber
Copy link
Owner

@privatenumber privatenumber commented Nov 23, 2023 •
edited
Loading

fix #218

In addition, this improves child process exit handling:

  • When a reload is triggered, it sends SIGTERM to the child, but if it doesn't exit within 5s, it sends a SIGKILL
  • When the watcher is exiting (e.g. Ctrl+C), it sends a SIGKILL if it doesn't exit within 5s
    • The rationale here is that you're quitting the watcher instead of the process. And it doesn't make sense that the child process can trap the watcher and prevent it from exiting.
  • Double Ctrl+C to force quit

@privatenumber privatenumber mentioned this pull request Nov 24, 2023
Closed
1 task
@privatenumber privatenumber changed the title feat(watch): log reason for rerun feat(watch): log reason for rerun & improvved exit handling Nov 24, 2023
@privatenumber privatenumber changed the title feat(watch): log reason for rerun & improvved exit handling feat(watch): log reason for rerun & improved exit handling Nov 24, 2023
@privatenumber privatenumber merged commit fb59907 into develop Nov 24, 2023
2 checks passed
@privatenumber privatenumber deleted the watch-why branch November 24, 2023 06:32
@karlhorky karlhorky mentioned this pull request Nov 24, 2023
Closed
@privatenumber
Copy link
Owner Author

🎉 This issue has been resolved in v4.5.0

If you appreciate this project, please consider supporting this project by sponsoring ❤️ 🙏

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add logging to watch function for easier troubleshooting
1 participant
@privatenumber