Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minify bundle #2

Closed
egoist opened this issue May 9, 2020 · 5 comments
Closed

Minify bundle #2

egoist opened this issue May 9, 2020 · 5 comments

Comments

@egoist
Copy link
Contributor

egoist commented May 9, 2020

No description provided.

@i5ting
Copy link

i5ting commented May 9, 2020

手是真快。牛逼

@egoist
Copy link
Contributor Author

egoist commented May 9, 2020

@i5ting Interested in contributing? 😄

@privatenumber
Copy link
Owner

I might be interested in helping add minification.

It's going to have to be a plugin though, and I'm not sure if it makes sense to add it to a package suffixed -loader (although I suppose vue-loader does).

What do you think?

@egoist
Copy link
Contributor Author

egoist commented Jul 23, 2020

@privatenumber this loader already uses a plugin to start esbuild service: https://github.com/egoist/esbuild-loader/blob/master/src/index.js#L42

@privatenumber
Copy link
Owner

Looks like it's been done https://github.com/sorrycc/esbuild-webpack-plugin

@privatenumber privatenumber mentioned this issue Aug 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@privatenumber @i5ting @egoist