Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add export for flag types #28

Conversation

transitive-bullshit
Copy link

Fixes #27

Unrelated question; do you use prettier? It surprised me when I went to contribute and my save by default made unrelated formatting changes w/ prettier defaults. I inferred what I think is close to your prettier config, but without a repo-specific prettier file, it makes it more difficult for folks to contribute. I'm sure you have a reason for doing things w/ your repos the way you do; I just want to understand :)

{
	"singleQuote": true,
	"trailingComma": "all",
	"useTabs": true
}

Thanks!

@transitive-bullshit
Copy link
Author

hmmm the CI error appears unrelated to this PR. I could push a fix but would rather keep the PR simple & focused on one thing.

@privatenumber
Copy link
Owner

No worries. The CI error is expected—it fails because it's a fork.

I'm using ESLint instead of Prettier. Stylistically, your changes look fine.

Just to double check, how are you planning to use Flags?

I think it's only used by cleye to enforce a base shape to the input flags (e.g. xyz extends Flags), so it should only be used in user-code like so: const sharedFlags = { ... } satisfies Flags.

But if that's the use-case, I'm wondering if const sharedFlags = { ... } as const would also suffice.

@privatenumber
Copy link
Owner

Closing due to lack of response. Happy to re-open when there's a response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export type Flags
2 participants