Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Unify integration test functions of each circuit #1099

Closed
ed255 opened this issue Jan 23, 2023 · 0 comments · Fixed by #1104
Closed

Unify integration test functions of each circuit #1099

ed255 opened this issue Jan 23, 2023 · 0 comments · Fixed by #1104
Assignees
@ed255
Labels
CI Issues related to the Continuous Integration mechanisms of the repository. T-refactor Type: cleanup/refactor

Comments

@ed255
Copy link
Member

ed255 commented Jan 23, 2023

Since all circuits now implement the SubCircuit trait, we can unify the integration tests so that they all reuse the same function which calls new_from_block and instances. This will also allow to test the correct behavior of the instances method.

Note that the SuperCircuit doesn't implement SubCircuit but we can easily add it in order to achieve this unification.

This should help avoiding these kind of issues in the future:
@ed255 ed255 added T-refactor Type: cleanup/refactor CI Issues related to the Continuous Integration mechanisms of the repository. labels Jan 23, 2023
@ed255 ed255 self-assigned this Jan 23, 2023
@ed255 ed255 moved this to 🏗 In progress in zkEVM Community Edition Jan 23, 2023
This was referenced Jan 23, 2023
Closed
Closed
Merged
@ed255 ed255 moved this from 🏗 In progress to 👀 In review in zkEVM Community Edition Jan 24, 2023
@ed255 ed255 moved this from 👀 In review to ✅ Done in zkEVM Community Edition Feb 1, 2023
SuccinctPaul pushed a commit to SuccinctPaul/zkevm-circuits that referenced this issue Feb 15, 2024
@noel2004
fix modexp input (privacy-scaling-explorations#1099)
913800e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ed255 ed255

Labels
CI Issues related to the Continuous Integration mechanisms of the repository. T-refactor Type: cleanup/refactor
Projects
zkEVM Community Edition
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: unify circuits in integration tests privacy-scaling-explorations/zkevm-circuits
1 participant
@ed255