Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pairing code to use pairing-0.23 instead of duplicating the code #66

Closed
CPerezz opened this issue Jul 11, 2023 · 1 comment · Fixed by #69
Closed

Migrate pairing code to use pairing-0.23 instead of duplicating the code #66

CPerezz opened this issue Jul 11, 2023 · 1 comment · Fixed by #69
Labels
enhancement New feature or request

Comments

@CPerezz
Copy link
Member

CPerezz commented Jul 11, 2023

In order to support curves like in #38 we need to be able to implement traits for them ONLY due to pairing.rs traits in halo2curves.

This, makes merging PRs like #38 really complex as we're forced to duplicate code. Otherwise we have a foreign structure implementing a foreign trait.

But, we can actually require the pairing::Engine-related deps from https://crates.io/crates/pairing and implement them inside of our crate for the curves defined on it (and it is already implemented for foreign curves which is fine).

@han0110 @kilic is there any issue that I'm missing that doing this implies?
@CPerezz CPerezz added the enhancement New feature or request label Jul 11, 2023
@kilic kilic mentioned this issue Jul 12, 2023
Merged
@davidnevadoc
Copy link
Contributor

Resolved by #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace pairing with zkcrypto/pairing kilic/halo2curves
2 participants
@davidnevadoc @CPerezz