Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a layer whitelist #9490

Closed
gomme600 opened this issue Mar 29, 2022 · 1 comment
Closed

Add a layer whitelist #9490

gomme600 opened this issue Mar 29, 2022 · 1 comment
Assignees
@priv-kweihmann
Labels
Feature request Not (yet) exisiting feature

Comments

@gomme600
Copy link

Is your feature request related to a problem? Please describe.

I am currently using SCA_SPARE_LAYER to blacklist layers and I would prefer to whitelist layers instead.
I don't want to inherit sca on each layer individually if possible.
@gomme600 gomme600 added the Feature request Not (yet) exisiting feature label Mar 29, 2022
@gomme600 gomme600 mentioned this issue Mar 29, 2022
Closed
@priv-kweihmann priv-kweihmann self-assigned this Mar 29, 2022
priv-kweihmann added a commit that referenced this issue Mar 29, 2022
@priv-kweihmann
Add a SCA_ALLOW_LAYER
1b9bf1f 
to further filter the layer/recipe where sca should be inherited
automatically

Closes #9490

Signed-off-by: Konrad Weihmann <[email protected]>
priv-kweihmann added a commit that referenced this issue Mar 29, 2022
@priv-kweihmann
Add a SCA_ALLOW_LAYER
03106b7 
to further filter the layer/recipe where sca should be inherited
automatically

Closes #9490

Signed-off-by: Konrad Weihmann <[email protected]>
priv-kweihmann added a commit that referenced this issue Mar 29, 2022
@priv-kweihmann
Add a SCA_ALLOW_LAYER
93bca02 
to further filter the layer/recipe where sca should be inherited
automatically

Closes #9490

Signed-off-by: Konrad Weihmann <[email protected]>
priv-kweihmann added a commit that referenced this issue Mar 29, 2022
@priv-kweihmann
Add a SCA_ALLOW_LAYER
9356a01 
to further filter the layer/recipe where sca should be inherited
automatically

Closes #9490

Signed-off-by: Konrad Weihmann <[email protected]>
@yangpeng1995
Copy link

Hi priv-kweihmann,
I recently found that the variable SCA_SPARE_LAYER is invalid when I enable SCA locally.
Then I debug found that it was caused by this submission.

I debug found that it was due to a problem with the judgment condition:
if _allow_list and x not in _allow_list:

The default variable of SCA_ALLOW_LAYER="".
So _allow_list = d.getVar("SCA_ALLOW_LAYER").split(" ")=[""].
But about judgment of "if _allow_list". In fact, "if [""]" value is true.
So this leads to always jumping out of the loop.

Can you help fix this bug?

@priv-kweihmann priv-kweihmann mentioned this issue Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priv-kweihmann priv-kweihmann

Labels
Feature request Not (yet) exisiting feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gomme600 @priv-kweihmann @yangpeng1995