fix(previews): correctly resolve the url
property in link fields
#542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This PR fixes a bug during previews where the
url
property in link fields always returnednull
.This happened because link fields are wrapped with
withDocumentProxy()
, which intercepts thedocument
andurl
properties to return the correct values in content relationship fields.withDocumentProxy()
was incorrectly returningnull
for all fields that are not content relationships.Note: Using
Proxy
is necessary to support content relationships and thedocument
property. In Gatsby's GraphQL API,document
refers to the linked document, which has full access to the document's data. If youconsole.log()
a link or content relationship field, you will see aProxy
object, not a standard object. This is normal.Fixes #541
Checklist: