Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output tree-shakeable module #59

Closed
nsivertsen opened this issue Sep 3, 2018 · 1 comment · Fixed by #60 or #105
Closed

Output tree-shakeable module #59

nsivertsen opened this issue Sep 3, 2018 · 1 comment · Fixed by #60 or #105

Comments

@nsivertsen
Copy link
Contributor

Currently, the build output is a single 32KB UMD bundle. Even if an app only does basic document fetches, it's forced to include everything else in its bundle as well.

Please consider also exporting an ES6 module in the package.module field.

@nsivertsen
Copy link
Contributor Author

Also, due to the way the global object is set up in the Webpack config you get the following warning when trying to use prismic-javascript as a module using Rollup:

The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant