-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate orderings
string values, resolves #269
#279
Conversation
Is it possible we could use Otherwise, everything looks good! |
I tried to do this at first yes, but no :/ I fixed the conflicts, and won't merge for now in case you want to play with it yourself~ LMK |
Again no pressure as it's a non urgent topic, but just a gentle ping |
I updated the PR with the following changes: Orderings
Filters — These changes are outside the scope of the PR but are similar to the ones above
I think that gives us the effect we want: don't break existing projects as a result of this change, but nudge developers to update their projects. If it looks good to you, this PR is good to merge! |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## v7 #279 +/- ##
==========================================
- Coverage 99.96% 99.92% -0.04%
==========================================
Files 48 49 +1
Lines 5281 5359 +78
Branches 303 309 +6
==========================================
+ Hits 5279 5355 +76
- Misses 2 4 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Awesome, thanks for the update 🙏 |
Types of changes
Description
Deprecate
orderings
string values and non-array values. See #269 for more details.This is a minor breaking change for TypeScript users, while still working, type checking won't pass for deprecated values anymore, this has been reflected in the migration guide.
Resolves: #269
Checklist: