Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue where getTags() returned an empty array for secured repositories #245

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

angeloashmore
Copy link
Member

@angeloashmore angeloashmore commented Jun 8, 2022

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR fixes an issue where a client's getTags() method could return an empty array ([]) rather than a list of the repository's tags. This could happen when a repository is proteted with an access token.

This happens because the client's access token was not being sent to the Tags API. This PR ensures the access token is sent if the Tags API is used.

Fixes #243

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

🐤

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

size-limit report 📦

Path Size
dist/index.js 4.09 KB (+0.29% 🔺)
dist/index.cjs 6.98 KB (+0.17% 🔺)

@angeloashmore angeloashmore merged commit b073edc into master Jun 8, 2022
@angeloashmore angeloashmore deleted the aa/fix-getTags-with-token branch June 8, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client.getTags() is broken.
1 participant