fix: on getAll methods, use MAX_PAGE_SIZE when pageSize param is falsey

[angeloashmore]

Types of changes

• Chore (a non-breaking change which is related to package maintenance)
• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

All getAll* methods default pageSize to MAX_PAGE_SIZE (currently 100). The default was only set if a pageSize parameter was not provided. For example, if a user provides a pageSize of undefined, pageSize will be undefined, not the default.

With this PR, pageSize will be set to MAX_PAGE_SIZE on any falsey value (including 0, undefined, null, and no value).

Checklist:

• My change requires an update to the official documentation.
• All TSDoc comments are up-to-date and new ones have been added where necessary.
• All new and existing tests are passing.

🦧

[lihbr]

I don't get why you moved the pageSize parameter below the lang one 🤔 is it only for styling purposes?

LGTM

[angeloashmore]

I don't get why you moved the pageSize parameter below the lang one 🤔 is it only for styling purposes?

It's due to the order of URL parameters. This PR makes pageSize always the last parameter. In the test, it compares the URL parameters as a string so order matters. It probably should convert it to an object and compare it (maybe t.deepEqual works on URLSearchParams).

Thanks for the review - I'll merge and publish.

[lihbr]

Oh OK, makes sense, works this way, no worries!