You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Config::trust_cert_ca method currently takes a path-parameter that looks like this: path: impl ToString which then gets converted to a PathBuf. Is there a reason the trust_cert_ca method doesn't take a PathBuf directly? I'd argue it would be more correct since there are valid paths that are not valid UTF-8 strings.
Current impl:
pubfntrust_cert_ca(&mutself,path:implToString){ifletTrustConfig::TrustAll = &self.trust{panic!("'trust_cert' and 'trust_cert_ca' are mutual exclusive! Only use one.")}else{self.trust = TrustConfig::CaCertificateLocation(PathBuf::from(path.to_string()))}}
Proposed impl:
pubfntrust_cert_ca(&mutself,path:implInto<PathBuf>){ifletTrustConfig::TrustAll = &self.trust{panic!("'trust_cert' and 'trust_cert_ca' are mutual exclusive! Only use one.")}else{self.trust = TrustConfig::CaCertificateLocation(path.into())}}
I'd be happy to send a PR!
The text was updated successfully, but these errors were encountered:
The
Config::trust_cert_ca
method currently takes a path-parameter that looks like this:path: impl ToString
which then gets converted to a PathBuf. Is there a reason thetrust_cert_ca
method doesn't take a PathBuf directly? I'd argue it would be more correct since there are valid paths that are not valid UTF-8 strings.Current impl:
Proposed impl:
I'd be happy to send a PR!
The text was updated successfully, but these errors were encountered: