Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previewFeatures = [] gets lost after Introspection #10460

Closed
janpio opened this issue Nov 26, 2021 · 0 comments · Fixed by prisma/prisma-engines#2546
Closed

previewFeatures = [] gets lost after Introspection #10460

janpio opened this issue Nov 26, 2021 · 0 comments · Fixed by prisma/prisma-engines#2546
Assignees
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. topic: introspection topic: previewFeatures Issue touches on an preview feature flag
Milestone

Comments

@janpio
Copy link
Contributor

janpio commented Nov 26, 2021

This is a valid schema:

generator client {
  provider        = "prisma-client-js"
  previewFeatures = []
}

datasource db {
  provider = "mysql"
  url      = "mysql://prisma:[email protected]:3306/Accidents"
}

After a db pull run it unfortunately looks like this:

generator client {
  provider        = "prisma-client-js"
}

datasource db {
  provider = "mysql"
  url      = "mysql://prisma:[email protected]:3306/Accidents"
}

model foo {
...

For some internal systems it would be nice if the empty previewFeatures array was kept after Introspection.

@janpio janpio added bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. process/candidate topic: introspection domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. labels Nov 26, 2021
@Jolg42 Jolg42 added this to the 3.7.0 milestone Dec 1, 2021
@Jolg42 Jolg42 added the topic: previewFeatures Issue touches on an preview feature flag label Dec 1, 2021
@Jolg42 Jolg42 modified the milestones: 3.7.0, 3.8.0 Dec 21, 2021
@pimeys pimeys self-assigned this Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. topic: introspection topic: previewFeatures Issue touches on an preview feature flag
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants