Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run yarn tests on node 18 #5197

Merged
merged 3 commits into from
Jul 8, 2024
Merged

fix: Run yarn tests on node 18 #5197

merged 3 commits into from
Jul 8, 2024

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Jul 8, 2024

They no longer work with node 16

They no longer work with node 16
@SevInf SevInf added this to the 5.17.0 milestone Jul 8, 2024
@SevInf SevInf marked this pull request as ready for review July 8, 2024 12:44
@SevInf SevInf requested review from janpio and a team as code owners July 8, 2024 12:44
@SevInf SevInf requested review from aqrln and Druue and removed request for a team July 8, 2024 12:44
@jkomyno
Copy link
Contributor

jkomyno commented Jul 8, 2024

Any clue why these tests suddently got broken? Do we have a lax yarn dependency version anywhere?

@SevInf SevInf merged commit 13eb6d5 into dev Jul 8, 2024
270 of 277 checks passed
@SevInf SevInf deleted the feat/yarn-node-18 branch July 8, 2024 12:51
@SevInf
Copy link
Contributor Author

SevInf commented Jul 8, 2024

It looks like we merge renovate PR regardless of engine failures, update happened and it was no longer compatible with 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants