Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin system package interface exports #158

Closed
jasonkuhrt opened this issue Dec 11, 2019 · 2 comments
Closed

plugin system package interface exports #158

jasonkuhrt opened this issue Dec 11, 2019 · 2 comments
Assignees
@jasonkuhrt
Labels
effort/easy note/breaking-change This issue existed already scope/plugins type/improve Something existing is made better, does not affect the interface (example: better error message)

Comments

@jasonkuhrt
Copy link
Member

jasonkuhrt commented Dec 11, 2019 •
edited
Loading

Instead of named create export consider default export. Seems simpler cleaner. Were seemingly blocked on prisma plugin due to usage of tsdx: jaredpalmer/tsdx#165
@jasonkuhrt jasonkuhrt added type/improve Something existing is made better, does not affect the interface (example: better error message) plugin-system labels Dec 11, 2019
@Weakky
Copy link
Collaborator

Weakky commented Dec 12, 2019

Another solution is simply not to use tsdx, right? Does it bring that much value right now?

@jasonkuhrt
Copy link
Member Author

Issue on tsdx side has since been fixed, no longer blocked.

@jasonkuhrt jasonkuhrt self-assigned this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonkuhrt jasonkuhrt

Labels
effort/easy note/breaking-change This issue existed already scope/plugins type/improve Something existing is made better, does not affect the interface (example: better error message)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonkuhrt @Weakky