Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept systems properties as well as environment variables #106

Closed
ianagbip1oti opened this issue Mar 25, 2018 · 0 comments
Closed

Accept systems properties as well as environment variables #106

ianagbip1oti opened this issue Mar 25, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers s T-Shirt size S

Comments

@ianagbip1oti
Copy link
Member

Currently ErisCasper accepts configuration via environment variables (e.g., EC_TOKEN=my.bot.token).

Java projects often respect system properties as well (e.g., -Dec.token=my.bot.token)

We should accept either. If both are given, prioritize the environment variable setting.
@ianagbip1oti ianagbip1oti added enhancement New feature or request good first issue Good for newcomers s T-Shirt size S labels Mar 25, 2018
@ianagbip1oti ianagbip1oti mentioned this issue Apr 3, 2018
Closed
@ianagbip1oti ianagbip1oti mentioned this issue Jun 3, 2018
Closed
This was referenced Jun 14, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers s T-Shirt size S
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianagbip1oti