Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all queries to L1 contracts are with respect to latest finalized block #429

Open
shaspitz opened this issue Oct 7, 2024 · 0 comments

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Oct 7, 2024

For simplicity (ie. to avoid edge cases) all client code should query any L1 contract using the latest finalized block, ensuring the client code to be reorg resistant. Relevant queries that need changes:

  • mev-commit p2p's querying for proposers api, which currently queries the validator opt-in router from the current l1 block.
  • Mev-commit bridge relayer blindly waits for transferInitiated events from 64 blocks in the past (worst case scenario finalization time), when it could be using the actual finalization time which varies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant