Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump erblint-github and make sure it is actually running. #2067

Merged
merged 7 commits into from
Jun 12, 2023
Merged

Bump erblint-github and make sure it is actually running. #2067

merged 7 commits into from
Jun 12, 2023

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Jun 8, 2023 •
edited
Loading

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

  • Bump erblint-github to latest
  • Enable latest rules
  • Make sure that the rules are actually running by creating .erb-linters/erblint-github.rb and requiring the rules from the gem.

Integration

No

List the issues that this change affects.

https://github.com/github/accessibility/issues/3766

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

I bumped the gem because it has new rules.

Anything you want to highlight for special attention from reviewers?

No

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@khiga8 khiga8 requested review from a team and camertron June 8, 2023 21:26
@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: d628444

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@khiga8 khiga8 temporarily deployed to preview June 8, 2023 21:26 — with GitHub Actions Inactive
@khiga8 khiga8 temporarily deployed to github-pages June 8, 2023 21:31 — with GitHub Actions Inactive
khiga8
khiga8 commented Jun 8, 2023
View reviewed changes
.erb-linters/erblint-github.rb
@@ -0,0 +1 @@
require "erblint-github/linters"
Copy link
Contributor Author

@khiga8 khiga8 Jun 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enabled rules weren't actually running because it wasn't being pulled in like this.

I don't believe there's a better way to inherit configs or rules from another gem in ERBLint

Related issue: Shopify/erb_lint#317.

@khiga8 khiga8 added the skip changeset Pull requests that don't change the library output label Jun 8, 2023
@khiga8
Copy link
Contributor Author

khiga8 commented Jun 8, 2023

moving to draft.

going to deprecate counter code from erblint-github which seems to interfere here.

@khiga8 khiga8 marked this pull request as draft June 8, 2023 22:20
@khiga8 khiga8 temporarily deployed to preview June 9, 2023 00:36 — with GitHub Actions Inactive
@khiga8 khiga8 temporarily deployed to github-pages June 9, 2023 00:41 — with GitHub Actions Inactive
@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Jun 9, 2023
khiga8
khiga8 commented Jun 9, 2023
View reviewed changes
app/components/primer/alpha/octicon_symbols.html.erb
@@ -1,3 +1,3 @@
<svg xmlns="http://www.w3.org/2000/svg" hidden>
<svg xmlns="http://www.w3.org/2000/svg" hidden> <%# erblint:disable GitHub::Accessibility::SvgHasAccessibleText %>
Copy link
Contributor Author

@khiga8 khiga8 Jun 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had trouble accessing the docs for this component. This should be addressed @primer/rails-reviewers

@khiga8 khiga8 temporarily deployed to github-pages June 9, 2023 21:11 — with GitHub Actions Inactive
@khiga8 khiga8 marked this pull request as ready for review June 9, 2023 21:15
@khiga8 khiga8 temporarily deployed to preview June 9, 2023 21:15 — with GitHub Actions Inactive
@khiga8 khiga8 temporarily deployed to github-pages June 9, 2023 21:19 — with GitHub Actions Inactive
@khiga8
Copy link
Contributor Author

khiga8 commented Jun 9, 2023

This is ready for another review.

@khiga8 khiga8 temporarily deployed to preview June 12, 2023 13:15 — with GitHub Actions Inactive
@khiga8 khiga8 temporarily deployed to github-pages June 12, 2023 13:19 — with GitHub Actions Inactive
@khiga8 khiga8 temporarily deployed to github-pages June 12, 2023 13:38 — with GitHub Actions Inactive
@khiga8
Copy link
Contributor Author

khiga8 commented Jun 12, 2023 •
edited
Loading

I don't have* merge authorization. Pls merge whenever ready!

@jonrohan jonrohan merged commit aa8b1e2 into main Jun 12, 2023
@jonrohan jonrohan deleted the kh-bump-erblint branch June 12, 2023 15:33
@khiga8 khiga8 mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@camertron camertron Awaiting requested review from camertron

Assignees
No one assigned
Labels
ruby Pull requests that update Ruby code skip changeset Pull requests that don't change the library output
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khiga8 @jonrohan