Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar Mask not being removed from DOM on close #869

Closed
craigrileyuk opened this issue Jan 19, 2021 · 1 comment
Closed

Sidebar Mask not being removed from DOM on close #869

craigrileyuk opened this issue Jan 19, 2021 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2-portable
Milestone

Comments

@craigrileyuk
Copy link

I'm getting this issue now too:

    "devDependencies": {
        "@vue/compiler-sfc": "^3.0.5",
        "laravel-mix": "^6.0.10",
        "postcss": "^8.2.4",
        "resolve-url-loader": "^3.1.0",
        "sass": "^1.32.4",
        "sass-loader": "^8.0.2",
        "vue": "^3.0.5",
        "vue-loader": "^16.1.2"
    },
    "dependencies": {
        "laravel-mix-alias": "^1.0.2",
        "mqpacker": "^7.0.0",
        "primeicons": "^4.1.0",
        "primevue": "^3.1.2"
    }

It seems to be related to the disableModality method inside the Sidebar component. The callback to remove the mask is attached to an event listener for transitionend on the mask element. However, while the mask fires a transitionend event when it opens (for the transform property), on my project, it doesn't fire one when it's closed, therefore the callback to remove the mask is never executed.

<template>
      <PrimeSidebar v-model:visible="navigation.showSidebar">
          Content
      </PrimeSidebar>
  </template>
  
  <script>
  import PrimeSidebar from "primevue/sidebar";
  import navigation from "@/store/navigation";
  
  export default {
      setup() {
          return {
              PrimeSidebar,
              navigation,
          };
      },
  };
  </script>

/*
* store/navigation.js
*/

import { reactive } from "vue";

export default reactive({
  showSidebar: false,
});

Originally posted by @craigrileyuk in #329 (comment)

@cagataycivici cagataycivici self-assigned this Jan 20, 2021
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jan 20, 2021
@cagataycivici cagataycivici added this to the 3.2.0-rc.1 milestone Jan 20, 2021
@cagataycivici
Copy link
Member

I've replicated it by adding a router link inside a sidebar, when the route changes, mask stays stuck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2-portable
Projects
None yet
Development

No branches or pull requests

2 participants