Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid "sortField" property type in Vue and type definition files #681

Closed
nestorrente opened this issue Nov 26, 2020 · 1 comment
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@nestorrente
Copy link
Contributor

This issue is related to #647. In that issue, @richardmward pointed that sortField prop of DataTable component was declared as String in the .vue file - that was fixed in version 3.0.2. However, the same issue is present in TableHeader and Column components. Also, Column.d.ts file has sortField defined as string, instead of string | Function.

The same issue is also present in DataTable, TableHeader and Column components of version 2.x - also in their corresponding type declaration files.

Refering to TypeScript definition files, it might be better to define it as string | ((item: any) => any), in order to give a little more information about function's signature.

Thank you very much for your time.

@cagataycivici cagataycivici self-assigned this Dec 9, 2020
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 9, 2020
@cagataycivici cagataycivici added this to the 3.1.0 milestone Dec 9, 2020
@cagataycivici
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants