Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: size variant still using hardcode size #6738

Open
zvn2060 opened this issue Nov 7, 2024 · 0 comments
Open

DataTable: size variant still using hardcode size #6738

zvn2060 opened this issue Nov 7, 2024 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@zvn2060
Copy link

zvn2060 commented Nov 7, 2024

Describe the bug

The datatable size variant (p-datatable-sm, p-datatable-lg) still using fixed value

.p-datatable.p-datatable-sm .p-datatable-header {
padding: 0.375rem 0.5rem;
}
.p-datatable.p-datatable-sm .p-datatable-thead > tr > th {
padding: 0.375rem 0.5rem;
}
.p-datatable.p-datatable-sm .p-datatable-tbody > tr > td {
padding: 0.375rem 0.5rem;
}
.p-datatable.p-datatable-sm .p-datatable-tfoot > tr > td {
padding: 0.375rem 0.5rem;
}
.p-datatable.p-datatable-sm .p-datatable-footer {
padding: 0.375rem 0.5rem;
}
.p-datatable.p-datatable-lg .p-datatable-header {
padding: 1rem 1.25rem;
}
.p-datatable.p-datatable-lg .p-datatable-thead > tr > th {
padding: 1rem 1.25rem;
}
.p-datatable.p-datatable-lg .p-datatable-tbody > tr > td {
padding: 1rem 1.25rem;
}
.p-datatable.p-datatable-lg .p-datatable-tfoot > tr > td {
padding: 1rem 1.25rem;
}
.p-datatable.p-datatable-lg .p-datatable-footer {
padding: 1rem 1.25rem;
}

image

Reproducer

https://stackblitz.com/edit/primevue-4-ts-vite-issue-template-qackuo?file=src%2FApp.vue

PrimeVue version

4.2.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

use Datatable component and assign the size property to small or large

Expected behavior

It should respect the new V4 design architecture

@zvn2060 zvn2060 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 7, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.3.0 milestone Nov 7, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Nov 7, 2024
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants