Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicDialog: Underlying dialog not destroyed #6535

Closed
YannisJustine opened this issue Oct 7, 2024 · 0 comments · Fixed by #6597
Closed

DynamicDialog: Underlying dialog not destroyed #6535

YannisJustine opened this issue Oct 7, 2024 · 0 comments · Fixed by #6597
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.2.2

Comments

@YannisJustine
Copy link
Contributor

Describe the bug

Closing a DynamicDialog does not destroy the underlying Dialog component. It does, however, multiply the number of css styles associated with dialog.
Old dialogs are no longer visible, but they are not destroyed.

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-safmim?file=src%2FApp.vue

PrimeVue version

4.1.0

Vue version

4.x

Language

ALL

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. Open a dynamic dialog
  2. Close the dialog
  3. Open again
  4. First dialog is not visible anymore but custom style aren't removed from the DOM and the component is not unmounted

Expected behavior

  1. Open a dynamic dialog
  2. Close the dialog
  3. Every css styles are removed from the DOM and the dialog component is unmounted
@YannisJustine YannisJustine added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 7, 2024
@YannisJustine YannisJustine mentioned this issue Oct 17, 2024
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 12, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.2.2 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.2.2
Development

Successfully merging a pull request may close this issue.

fix: Destroy dialog instance on close to release unused memory YannisJustine/primevue
2 participants
@tugcekucukoglu @YannisJustine