Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload: Fix type of FileUploadState.messages #6370

Closed
jacobtylerwalls opened this issue Sep 10, 2024 · 0 comments · Fixed by #6322
Closed

FileUpload: Fix type of FileUploadState.messages #6370

jacobtylerwalls opened this issue Sep 10, 2024 · 0 comments · Fixed by #6322
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.0.7

Comments

@jacobtylerwalls
Copy link
Contributor

Describe the bug

FileUploadState.messages is typed as any[], but it's actually string[] | null:

primevue/packages/primevue/src/fileupload/FileUpload.vue

Line 239 in dcd66c1

this.messages = null;

Reproducer

primevue/packages/primevue/src/fileupload/FileUpload.vue

Line 239 in dcd66c1

this.messages = null;

PrimeVue version

4.0.1

Vue version

4.x

Language

TypeScript

Build / Runtime

TypeScript

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@jacobtylerwalls jacobtylerwalls added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 10, 2024
@jacobtylerwalls jacobtylerwalls mentioned this issue Sep 10, 2024
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 10, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.0.7 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.0.7
Development

Successfully merging a pull request may close this issue.

Improve typing of FileUploadState.messages jacobtylerwalls/primevue
2 participants
@tugcekucukoglu @jacobtylerwalls