Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect: 'v-if="filter"' erroneously removed in v4 #5978

Closed
goldengecko opened this issue Jun 27, 2024 · 1 comment
Closed

MultiSelect: 'v-if="filter"' erroneously removed in v4 #5978

goldengecko opened this issue Jun 27, 2024 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@goldengecko
Copy link

Describe the bug

Line 89 should have v-if="filter" on the IconField element. It used to be there in the equivalent code in v3.

The impact of it not being there is that you can't display the select/deselect all checkbox without also showing the search field.

Reproducer

N/A

PrimeVue version

4.0.0-rc2

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

Create a MultiSelect and don't add the filter option. The toggleShowAll checkbox will appear as expected, but the filter textfield will also be shown which is incorrect.

Expected behavior

Filter should only be shown when the filter attribute is set.

@goldengecko goldengecko added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 27, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 28, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Jun 28, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.0.0-rc.4 milestone Jun 28, 2024
@tugcekucukoglu
Copy link
Member

Contribute to the project by submitting a PR and add value to our community! Share your improvements and enhancements; we look forward to your feedback! PR's always welcomed.

@tugcekucukoglu tugcekucukoglu modified the milestones: 4.0.0-rc.4, 4.0.0 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants