Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileUpload Preview columns become misaligned when both image and non-image files are uploaded #585

Closed
Christoph-Wagner opened this issue Oct 19, 2020 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Christoph-Wagner
Copy link
Contributor

This affects both the Vue 2 and 3 version of PrimeVue and can be seen at the showcase by selecting an image file and a text file:

image

It’s because the row has

<div v-if="isImage(file)">
    <img role="presentation" :alt="file.name" :src="file.objectURL" :width="previewWidth" />
</div>

a simple solution would be to do

<div>
    <img v-if="isImage(file)" role="presentation" :alt="file.name" :src="file.objectURL" :width="previewWidth" />
</div>

instead, but I guess that would be suboptimal if only non-images are uploaded.

@cagataycivici cagataycivici self-assigned this Nov 25, 2020
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 25, 2020
@cagataycivici cagataycivici added this to the 3.0.2 milestone Nov 25, 2020
@cagataycivici
Copy link
Member

Should be fine with your suggestion, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants