Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare events in "emits" section of every component #549

Closed
LadislavBohm opened this issue Oct 13, 2020 · 1 comment
Closed

Declare events in "emits" section of every component #549

LadislavBohm opened this issue Oct 13, 2020 · 1 comment
Assignees
@cagataycivici
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.0.1

Comments

@LadislavBohm
Copy link

Currently when using primevue in Vue 3 it gives you a warning every time an event is emitted because it's not declared in 'emits' section.

image

It would be nice to have those events declared at least using the array syntax:

emits: ['row-select', 'row-unselected', ...]
@cagataycivici cagataycivici self-assigned this Oct 20, 2020
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Oct 20, 2020
@cagataycivici cagataycivici added this to the 3.0.1 milestone Oct 20, 2020
@cagataycivici
Copy link
Member

We'll do it, thank you.

@LadislavBohm LadislavBohm mentioned this issue Oct 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.0.1
Development

No branches or pull requests
2 participants
@cagataycivici @LadislavBohm