Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Timepicker changes from 12 am to 12 pm automatically #4449

Closed
zernonia opened this issue Sep 14, 2023 · 4 comments
Closed

Calendar: Timepicker changes from 12 am to 12 pm automatically #4449

zernonia opened this issue Sep 14, 2023 · 4 comments
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@zernonia
Copy link
Contributor

zernonia commented Sep 14, 2023

Describe the bug

The timepicker in calendar changes from manual input 12:30 am to 12:30 pm when lose focus.

Reproducer

https://codesandbox.io/p/sandbox/quizzical-hooks-xlmrqd?welcome=true

PrimeVue version

3.34.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

(important: having props = hour-format="12", time-only)

  1. Open the repro link
  2. Manually change the input to 12: 30 am, click outside from the input
  3. Observe the am changed to pm
Screen.Recording.2023-09-14.at.10.34.38.PM.mov

Expected behavior

It should remain 12: 30 am.

@zernonia zernonia added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 14, 2023
@zernonia zernonia changed the title Calendar: Timepicker Calendar: Timepicker changes from 12 am to 12 pm automatically Sep 14, 2023
@zernonia
Copy link
Contributor Author

PR is ready 😁
#4451

@mertsincan mertsincan added this to the 3.35.1 milestone Oct 5, 2023
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 5, 2023
@mertsincan
Copy link
Member

Fixed in #4451

@dmhendricks
Copy link

@mertsincan - I'm trying to figure out if I'm crazy or if this bug still exists in 3.36.0. I can reproduce it on the documentation page demo...

To reproduce it:

  1. Go here: https://primevue.org/calendar/
  2. Select a date and time. Make the time 12:xx am. Example:
Screenshot 2023-10-11 at 10 56 36 AM
  1. Click off of field to remove focus (you can click anywhere else on the page)
  2. Click on the field again and select any date. When you do that, the "am" will automatically change to "pm" even though the time wasn't changed/touched:
Screenshot 2023-10-11 at 10 58 51 AM

@dmhendricks
Copy link

dmhendricks commented Jan 18, 2024

This is still happening in 3.46.0, including on the documentation page, as described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants