Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatable: Menu Filter Icon Click Causes Column to Sort #4268

Closed
fireblazer9 opened this issue Aug 14, 2023 · 1 comment · Fixed by RMI-PACTA/app#156
Closed

Datatable: Menu Filter Icon Click Causes Column to Sort #4268

fireblazer9 opened this issue Aug 14, 2023 · 1 comment · Fixed by RMI-PACTA/app#156
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@fireblazer9
Copy link

Describe the bug

A bug was introduced in 3.32.0 whereby when using sortable columns, and filterDisplay="menu", clicking on the filter menu icon within the column header causes the column to sort at the same time. This can be seen in the examples on the documentation, or in the included reproducer (taken from the Samples > Customers section).

In 3.31.0 the icon can be pressed and the menu appears without causing the column to sort.

Reproducer

https://codesandbox.io/s/vlcj8x

PrimeVue version

3.32.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

  1. Add a Datatable with a column that is sortable
  2. Add a filter with filterDisplay="menu"
  3. Click the filter icon to display the menu
  4. The table will sort at the same time

Expected behavior

As per 3.31.0 the filter menu box should appear without the column being sorted at the same time.

@fireblazer9 fireblazer9 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 14, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 15, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.32.1 milestone Aug 15, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Aug 15, 2023
@leecraigjeffries
Copy link

This is still an issue, I don't know why it is classed as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants