Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowEmpty property to SelectButton #3973

Closed
jnoordsij opened this issue May 19, 2023 · 4 comments · Fixed by #4107
Closed

Add allowEmpty property to SelectButton #3973

jnoordsij opened this issue May 19, 2023 · 4 comments · Fixed by #4107
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@jnoordsij
Copy link

jnoordsij commented May 19, 2023

Describe the bug

In #3610 and #3708, the behavior for the unselectable was reversed. This is very confusing, as it is dubious wether or not this is an improvement to the logic.

Moreover it certainly is a breaking change of behavior and should not have been added in a minor version update.

For further reference, please see #3708 (comment) and below.

@jnoordsij jnoordsij added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 19, 2023
@rubjo
Copy link
Contributor

rubjo commented May 31, 2023

I really cannot see how this is dubious at all, the behaviour reversal was unfortunately just wrong.

All of these are logically the same:
unselectable
possible to unselect
possible to clear
clearable
can be blank

If another wording is less likely to be misinterpreted, I agree with @jnoordsij that this should be fixed as per his suggestion in #3708.

@kennyfellows
Copy link

Agreed. I had to read the code to figure out why I needed :unselectable="false" in order for it to be unselectable.

@colinstevens06
Copy link

Agreed. Is not intuitive as it currently is labeled. Now that I know, I know, but I expected it to perform the opposite of how it does based on the naming of the prop.

@jnoordsij
Copy link
Author

This has been adressed in #4107, by deprecating the old flag and introducing a non-ambiguous new flag. Would be great to have it merged!

@mertsincan mertsincan changed the title SelectButton: incorrectly adjusted unselectable behavior Add allowEmpty property to SelectButton Oct 9, 2023
@mertsincan mertsincan added Type: New Feature Issue contains a new feature or new component request and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 9, 2023
@mertsincan mertsincan added this to the 3.35.1 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants