You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After 3.27, there were a couple of refactored bits released, but that seems to have greatly broken some functionality (in my app at least). More specifically, I refer to the Button component with this LOC:
This is causing issues in cases where a wrapper button is created like so:
<Button:label="'fallback text if no slot'" class="my-custom-wrapper-class"><slot />
</Button>
Because if this button is used without the inner slot being used, it would be empty but $slots.default would be true. Please refer to the reproduction to see what I'm talking about.
mertsincan
added
Type: Enhancement
Issue contains an enhancement related to a specific component. Additional functionality has been add
and removed
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
labels
Apr 27, 2023
Describe the bug
After 3.27, there were a couple of refactored bits released, but that seems to have greatly broken some functionality (in my app at least). More specifically, I refer to the Button component with this LOC:
primevue/components/lib/button/Button.vue
Line 4 in bcb93b5
This is causing issues in cases where a wrapper button is created like so:
Because if this button is used without the inner slot being used, it would be empty but
$slots.default
would be true. Please refer to the reproduction to see what I'm talking about.Reproducer
https://stackblitz.com/edit/angular-heuv8g?file=src/App.vue
PrimeVue version
3.27.0
Vue version
3.x
Language
TypeScript
Build / Runtime
Vue CLI App
Browser(s)
No response
Steps to reproduce the behavior
No response
Expected behavior
No response
The text was updated successfully, but these errors were encountered: