Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: cannot unbind events when tooltip value is cleared #3645

Closed
fangd1997 opened this issue Feb 9, 2023 · 2 comments · Fixed by #3644
Closed

Tooltip: cannot unbind events when tooltip value is cleared #3645

fangd1997 opened this issue Feb 9, 2023 · 2 comments · Fixed by #3644
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.25.0

Comments

@fangd1997
Copy link
Contributor

fangd1997 commented Feb 9, 2023 •
edited
Loading

Describe the bug

image
should be if (ObjectUtils.isEmpty(options.value.value) || options.value.value.trim() === '')

Reproducer

https://github.com/primefaces/primevue/blob/master/components/tooltip/Tooltip.js#L326
https://github.com/primefaces/primevue/blob/master/components/tooltip/Tooltip.js#L369
Comparing these two lines, it can find that 369 lines are wrong

PrimeVue version

3.23.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@fangd1997 fangd1997 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 9, 2023
@fangd1997 fangd1997 mentioned this issue Feb 9, 2023
Merged
@fangd1997 fangd1997 changed the title Cannot read properties of undefined (reading 'trim') in tooltip Cannot read properties of undefined (reading 'trim') in tooltip.js Feb 9, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 16, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.23.1 milestone Feb 16, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Feb 16, 2023
@mertsincan mertsincan modified the milestones: 3.23.1, 3.24.0 Mar 2, 2023
@tugcekucukoglu tugcekucukoglu added Resolution: Cannot Replicate Issue could not be replicated by Core Team and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

We're unable to replicate your issue, if you are able to create a reproducer or add details please edit this issue. This issue will be closed if no activities in 20 days.

@tugcekucukoglu tugcekucukoglu removed this from the 3.24.0 milestone Mar 7, 2023
@fangd1997
Copy link
Contributor Author

fangd1997 commented Mar 7, 2023 •
edited
Loading

https://github.com/primefaces/primevue/blob/master/components/tooltip/Tooltip.js#L326
https://github.com/primefaces/primevue/blob/master/components/tooltip/Tooltip.js#L369
326:image
369image
Comparing these two lines, it can find that 369 lines are wrong. The position of ")" is incorrect.
fixed by #3644
@tugcekucukoglu

@tugcekucukoglu tugcekucukoglu changed the title Cannot read properties of undefined (reading 'trim') in tooltip.js Tooltip: cannot unbind events when tooltip value is cleared Mar 13, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Resolution: Cannot Replicate Issue could not be replicated by Core Team labels Mar 13, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.24.1 milestone Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.25.0
Development

Successfully merging a pull request may close this issue.

fix trim undefined in tooltip.js fangd1997/primevue
3 participants
@mertsincan @tugcekucukoglu @fangd1997