Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale: endsWith typing error on d.ts #3595

Closed
albinabc opened this issue Jan 27, 2023 · 0 comments
Closed

Locale: endsWith typing error on d.ts #3595

albinabc opened this issue Jan 27, 2023 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@albinabc
Copy link

albinabc commented Jan 27, 2023

Describe the bug

Hello, I found a bug, and also the solution to the bug. You have defined PrimeVueLocaleOptions with the property "endWith", but this is a typo. The actual property should be "endsWith".
The following works:

locale: {
    endsWith: 'Endet mit',
  },

While the following does not:

locale: {
    endWith: 'Endet mit',
  },

Following is a small snippet from the LocaleOptions:

interface PrimeVueLocaleOptions {
    startsWith?: string;
    contains?: string;
    notContains?: string;
    endWith?: string;
    equals?: string;
}

And this is why I'd like it to be fixed:
image

Reproducer

PrimeVue version

3.22.3

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

The property in the LocaleOptions should be endsWith.

@albinabc albinabc added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 27, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Jan 27, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.23.0 milestone Jan 27, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 27, 2023
@tugcekucukoglu tugcekucukoglu changed the title PrimeVueLocaleOptions Typo [SOLUTION IS IN THE ISSUE] Locale: endsWith error on d.ts Jan 27, 2023
@tugcekucukoglu tugcekucukoglu changed the title Locale: endsWith error on d.ts Locale: endsWith typing error on d.ts Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants