Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Regression. Incorrect calendar pop-up positioning when used as editor in DataTable #3526

Closed
jpeletier opened this issue Jan 12, 2023 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@jpeletier
Copy link
Contributor

Describe the bug

As of PrimeVue 3.13.0, when using Calendar inside an editable DataTable, the calendar pop-up is located at coordinates (0,0) instead of relative to the date entry box.

You can see the issue in the provided sandbox. If PrimeVue is set to 3.13.0 or higher, the calendar pop-up shows incorrectly.
If PrimeVue is set to 3.12.6 or lower, the calendar pop-up shows correctly.

Reproducer

https://codesandbox.io/s/magical-oskar-4quum9

PrimeVue version

3.13.0

Vue version

3.x

Language

ALL

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

In the demo, check that you can input dates in the standalone Calendar (outside DataTable). This works in all versions. After that, click on any date in the table below to see that the Calendar shows somewhere else for PrimeVue 3.13.0 or higher.

Expected behavior

Same behavior as with 3.12.6: the Calendar shows relative to the Calendar textbox.

@jpeletier jpeletier added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 12, 2023
@jpeletier
Copy link
Contributor Author

Here is a diff of Calendar.vue between 3.12.6 -> 3.13.0. Looks like the issue could be related with the change from Teleport to Portal.

src/components/calendar/Calendar.vue. (When clicking this link, allow for 10-15 seconds for it tho show the actual diff)

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 16, 2023
@mertsincan mertsincan added this to the 3.23.0 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants