Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete prop types specified in Column #2097

Closed
harveylee opened this issue Feb 3, 2022 · 0 comments
Closed

Incomplete prop types specified in Column #2097

harveylee opened this issue Feb 3, 2022 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@harveylee
Copy link
Contributor

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

Current behavior

Spurious Vue warnings printed in the console when using functions for Column field prop, e.g.:
[Vue warn]: Invalid prop: type check failed for prop "field". Expected String with value "d => d.calculateField(myVar)", got Function

Expected behavior

No warnings from Vue for valid code.

Minimal reproduction of the problem with instructions

  1. Create a DataTable
  2. Add a Column
  3. Use a function for the field property

What is the motivation / use case for changing the behavior?

The use of functions is supported but prop types for field and filterField do not include Function. Related to #1078, which corrected the Typescript definitions but not the Vue prop types.

Please tell us about your environment:

  • Vue version: 3.2.26
  • PrimeVue version: 3.8.1
  • Browser: Chrome Version 97.0.4692.99 (Official Build) (64-bit) Windows
@tugcekucukoglu tugcekucukoglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Feb 9, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.11.2 milestone Feb 11, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants