Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: "notIn" mode for Datatable filters #5460

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Feature: "notIn" mode for Datatable filters #5460

merged 4 commits into from
Mar 25, 2024

Conversation

dnyaneshwar2023
Copy link
Contributor

@dnyaneshwar2023 dnyaneshwar2023 commented Nov 30, 2023 •
edited
Loading

Fix #5450

@vercel Vercel
Copy link

vercel bot commented Nov 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 1:59pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 1:59pm

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@dnyaneshwar2023
Copy link
Contributor Author

Hi Team,
Since I introduced "notIn" filter in FilterService, should I update type declarations for following components as well?
I have updated it for DataTable.

Components using FilterService:
DataTable
Dropdown
ListBox
Multiselect
OrderList
PickList
TreeTable

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

2 similar comments
@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@dnyaneshwar2023 dnyaneshwar2023 mentioned this pull request Nov 30, 2023
Closed
@melloware
Copy link
Member

Yes I think it should be updated anywhere filters are defined.

@melloware melloware added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 30, 2023
@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@dnyaneshwar2023
Copy link
Contributor Author

dnyaneshwar2023 commented Nov 30, 2023 •
edited
Loading

@melloware

Yes I think it should be updated anywhere filters are defined.

I added it in the following components since they were using "in" matchMode so it makes sense to add "notIn" there.

  • TreeTable
  • Column
  • PickList

melloware added a commit to melloware/primereact that referenced this pull request Dec 22, 2023
@melloware
Fix primefaces#5460: Column dynamically evaluate rowEditor
ba3633b
@melloware melloware mentioned this pull request Dec 22, 2023
Merged
@melloware melloware closed this in 27042f0 Dec 22, 2023
@dnyaneshwar2023
Copy link
Contributor Author

@melloware I am not sure, why this was closed. I didn't got why pull request #5460 mentioned while closing this, looks like it's not related to this pull request.

@melloware melloware reopened this Dec 23, 2023
@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware
Copy link
Member

It was accidental.

@dnyaneshwar2023
Copy link
Contributor Author

It was accidental.

Ok, Thanks for reopening.

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@mertsincan mertsincan merged commit 54df499 into primefaces:master Mar 25, 2024
5 of 6 checks passed
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datatable: "not-in" mode for filter function
3 participants
@dnyaneshwar2023 @melloware @mertsincan