Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-table cell edit wrong index on onEditComplete event #9075

Closed
MrCosmo opened this issue Jul 27, 2020 · 0 comments
Closed

p-table cell edit wrong index on onEditComplete event #9075

MrCosmo opened this issue Jul 27, 2020 · 0 comments
Assignees
Labels
LTS-FIXED-9.2.4 Fixed in PrimeNG LTS 9.2.4 LTS-FIXED-10.0.9 Fixed in PrimeNG LTS 10.0.9 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@MrCosmo
Copy link

MrCosmo commented Jul 27, 2020

I'm submitting a ... (check one with "x")

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
https://stackblitz.com/edit/github-yvvksh

Current behavior
When clicking a cell in the first row, onEditInit event emits. The data in that event shows that the index of the row is 0 (zero).
When you click a cell in the second row, onEditComplete event emits. The data in that event shows that the index of the row is 1.

Expected behavior
The data in onEditComplete should emit the same rowindex as was emitted on OnEditInit.

Minimal reproduction of the problem with instructions

  • Start cell edit by clicking one of the cells in the table, as provided in the Plunkr above.
  • Note that the log writes the current index of the row you clicked
  • Click another cell in another row
  • Note that onEditComplete event triggers with the index of the row you clicked in the step above

Please tell us about your environment:

  • Windows 10

  • VS Code

  • Angular version: 9.1.7

  • PrimeNG version: 9.1.0

  • Browser: all

  • Language: all

  • Node (for AoT issues): node --version = 12.13.0

@yigitfindikli yigitfindikli self-assigned this Nov 24, 2020
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 24, 2020
@yigitfindikli yigitfindikli added this to the 11.0.1 milestone Nov 24, 2020
@yigitfindikli yigitfindikli modified the milestones: 11.0.0-Final, 11.0.1 Dec 7, 2020
@yigitfindikli yigitfindikli removed this from the 11.1.0 milestone Dec 29, 2020
@yigitfindikli yigitfindikli removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Dec 29, 2020
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 29, 2020
@yigitfindikli yigitfindikli added this to the 11.1.0 milestone Dec 29, 2020
@yigitfindikli yigitfindikli added LTS-FIXED-10.0.9 Fixed in PrimeNG LTS 10.0.9 LTS-FIXED-9.2.4 Fixed in PrimeNG LTS 9.2.4 and removed LTS-PORTABLE labels Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-9.2.4 Fixed in PrimeNG LTS 9.2.4 LTS-FIXED-10.0.9 Fixed in PrimeNG LTS 10.0.9 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants