Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Dialog close button needs aria- label #8947

Closed
T-jain1995 opened this issue Jun 15, 2020 · 1 comment
Closed

Accessibility: Dialog close button needs aria- label #8947

T-jain1995 opened this issue Jun 15, 2020 · 1 comment
Assignees
Labels
LTS-FIXED-9.1.8 Fixed in PrimeNG LTS 9.1.8 LTS-FIXED-10.0.5 Fixed in PrimeNG LTS 10.0.5 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@T-jain1995
Copy link

T-jain1995 commented Jun 15, 2020

I'm submitting a ... (check one with "x")

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior

When tabbing through the paging controls with a screen reader, the dialog close button is not readout.

Expected behavior
The screen reader should speak (vi aria-label) when tabbed to each control i.e "Close button".
add aria-label to the button. Ex: aria-label = "close",

Minimal reproduction of the problem with instructions

Capture

What is the motivation / use case for changing the behavior?
This will be helpful by the specially-abled people.

Please tell us about your environment:
Windows, NPM, Angular, VSCode

  • Angular version: - 9.1.9

  • PrimeNG version: - 9.0.6

  • Browser: [ chrome, edge]

  • Language: [TypeScript - 3.8.3]

  • Node (for AoT issues): node --version =

@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jun 16, 2020
@yigitfindikli yigitfindikli self-assigned this Oct 20, 2020
@yigitfindikli yigitfindikli added this to the 10.1.0 milestone Oct 20, 2020
@yigitfindikli yigitfindikli added the LTS-FIXED-9.1.8 Fixed in PrimeNG LTS 9.1.8 label Nov 9, 2020
@XxOsirisxX77
Copy link

The commit that was done in here to close this issue, only adds aria-label to the approve / reject buttons, but not the close icon at the top right, which should be aria-labeled as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-9.1.8 Fixed in PrimeNG LTS 9.1.8 LTS-FIXED-10.0.5 Fixed in PrimeNG LTS 10.0.5 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

3 participants