Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-table: custom sort should not be invoked if lazy is true #16370

Open
MikeMatusz opened this issue Sep 11, 2024 · 3 comments
Open

p-table: custom sort should not be invoked if lazy is true #16370

MikeMatusz opened this issue Sep 11, 2024 · 3 comments
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team

Comments

@MikeMatusz
Copy link
Contributor

MikeMatusz commented Sep 11, 2024

Describe the bug

If I configuring the p-table for lazy-loading, the sort should be handled on the server or in the onLazyLoad function, otherwise the sort has only a portion of the total data source available. And if we are already sorting on the server, it tries to run additional client-side logic to sort, which may conflict.

Numerous issues have come up in the past about using them together, and the response has always been the same as above. That changed suddenly with #15550 and caused issues we had to work around in our code. This was a breaking change, not a fix, and I'm not sure the utility of it.

If new records are returned when you load the next page, the client-side sort might interleave them with the first set of results, which would be a very confusing user experience. I can't think of a good use case for supporting this, as it seems like it could only cause undesirable behavior.

Environment

N/A

Reproducer

No response

Angular version

17

PrimeNG version

17

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@MikeMatusz MikeMatusz added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 11, 2024
@mertsincan
Copy link
Member

Could you please try the latest version?

@mertsincan mertsincan added Resolution: Cannot Replicate Issue could not be replicated by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

We're unable to replicate your issue, if you are able to create a reproducer by using PrimeNG Issue Template or add details please edit this issue. This issue will be closed if no activities in 20 days.

@MikeMatusz
Copy link
Contributor Author

I cannot replicate the issue in the latest version. Looking at the code I believe this was fixed by #16235.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team
Projects
None yet
Development

No branches or pull requests

2 participants