Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Performance degradation for the table with pFrozenColumn #15922

Closed
sd-git opened this issue Jun 28, 2024 · 2 comments
Closed

Table: Performance degradation for the table with pFrozenColumn #15922

sd-git opened this issue Jun 28, 2024 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@sd-git
Copy link

sd-git commented Jun 28, 2024

Describe the bug

After upgrading PrimeNG 17.14.1 -> 17.15.0 screen resize events started to flood components with change detection event and for non-trivial table with a lot of rows this is significant performance impact (up to the hanging devtools in debug mode).

After looking through the code changes between 17.14.1 and 17.15.0 this could be the potential trigger for degradation: #15302

The latest version of PrimeNG 17.18.2 is also affected.

Environment

Reproducible with stackblitz example and simplest table

Reproducer

https://stackblitz.com/edit/github-my8zxt?devToolsHeight=33&file=src%2Fapp%2Fmy-table%2Fmy-table.component.html

Angular version

17.3.11

PrimeNG version

17.18.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.3

Browser(s)

Chrome 126

Steps to reproduce the behavior

  1. Open stackblitz example project
  2. Click on 'Add row' button to add some more rows
  3. Resize preview window and monitor change detection counter rapidly raising.
  4. Downgrade to PrimeNG version 17.14.1 and repeat steps 1-3
  5. Notice that resizing preview does not trigger massive CD events/ impact performance

Expected behavior

Same as in 17.14.1 - no massive CD events during screen/viewport resizing when table with pFrozenColumn is rendered.

@sd-git sd-git added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 28, 2024
@phalla-doll
Copy link

+1

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation and try the latest PrimeNG version(v19). If there is no improvement on this, can you open a new issue so we can include it in our roadmap?

Thanks a lot for your understanding!
Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants