Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: Clear function does not clear all filters #12903

Closed
Kisters-BS opened this issue Apr 17, 2023 · 0 comments · Fixed by #12904
Closed

Table: Clear function does not clear all filters #12903

Kisters-BS opened this issue Apr 17, 2023 · 0 comments · Fixed by #12904
Labels
LTS-FIXED-13.4.3 LTS-FIXED-14.2.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.0.0-rc.1

Comments

@Kisters-BS
Copy link
Contributor

Describe the bug

The clear function does only clear the table column filters and the global filter. Additional filters set by the filter function are ignored.

Environment

See stackblitz

Reproducer

https://stackblitz.com/edit/github-w2zrds-cp1ngc

Angular version

15.2.2

PrimeNG version

15.2.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.19.0

Browser(s)

Firefox 112.0, Chrome 112.0

Steps to reproduce the behavior

  1. Click on the filter button
  2. Click on the reset filter button
  3. Look at the filters array: The quantity filter value is still present

Expected behavior

The clear function should clear all filters
@Kisters-BS Kisters-BS added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 17, 2023
@Kisters-BS Kisters-BS mentioned this issue Apr 17, 2023
Merged
@cetincakiroglu cetincakiroglu added this to the 15.4.1 milestone Apr 20, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 20, 2023
@cetincakiroglu cetincakiroglu modified the milestones: 15.4.1, 15.Future, 15.4.2 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-FIXED-13.4.3 LTS-FIXED-14.2.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.0.0-rc.1
Development

Successfully merging a pull request may close this issue.

Fix clear function not resetting all filters Kisters-BS/primeng
3 participants
@gucal @cetincakiroglu @Kisters-BS