Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table | Unable to reorder to the last element in the table after a scroll occurs #12493

Closed
NinkevdVeen opened this issue Jan 13, 2023 · 0 comments · Fixed by #12853
Closed

Table | Unable to reorder to the last element in the table after a scroll occurs #12493

NinkevdVeen opened this issue Jan 13, 2023 · 0 comments · Fixed by #12853
Labels
LTS-FIXED-13.4.3 LTS-FIXED-14.2.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@NinkevdVeen
Copy link

Describe the bug

We have encountered some behaviour which is a bit confusing/illogical and we think is incorrect, hence this bug report.

When ordering in the table with Reorder you can pick up the last item. When moving it slightly up the drop area is visible just above the picked up item. So the area between the last item and the item before last.
When I drop this last item there I expect it to be dropped where it used to be, but instead it is moved 1 row before.

I saw there were some issues with the last item and scrolling, so perhaps there is some relation? (#10003)

Environment

Can be found in the documentation: https://primefaces.org/primeng/table/reorder -> so this concerns latest versions, but I have added versions as described in provided stackblitz (https://stackblitz.com/edit/primeng-tablereorder-demo) as well as our tested versions

  • Latest Firefox: currently 108.0.2
  • Latest Chrome: currently 109.0.5414.87
  • OS: MacOs, but also seen in Linux

Reproducer

https://stackblitz.com/edit/primeng-tablereorder-demo

Angular version

13.0.3 and 14.2.6

PrimeNG version

13.0.4 and 14.1.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18 and 16

Browser(s)

latest Firefox & Chrome, possibly others

Steps to reproduce the behavior

  1. go to either https://primefaces.org/primeng/table/reorder or https://primeng-tablereorder-demo.stackblitz.io
  2. click and hold last item in list (gaming set, which is below game controller)
  3. move it up a couple of pixels, you will see a drop area right below game controller, and above item you are holding(gaming set).
  4. drop the game set in that drop area, so between current item and item above current.
  5. Game set should not move, or just move to the same position, but instead has moved above game controller and has become item before last.

This happens when you drag Gaming set above game controller as well, but that is expected behaviour.

Expected behavior

When dragging last item in list (Gaming set) between last item(gaming set) and item before last (Gaming controller) I expect the item to move there, which mean to actually not move at all.
I do not expect it to move before the item before last, above game controller.

@NinkevdVeen NinkevdVeen added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 13, 2023
@cetincakiroglu cetincakiroglu changed the title Table Reorder last item drop behaviour Table Unable to reorder to the last element in the table after a scroll occurs #10003 Apr 25, 2023
@cetincakiroglu cetincakiroglu changed the title Table Unable to reorder to the last element in the table after a scroll occurs #10003 Table | Unable to reorder to the last element in the table after a scroll occurs Apr 25, 2023
@cetincakiroglu cetincakiroglu added this to the 15.4.2 milestone Apr 25, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-13.4.3 LTS-FIXED-14.2.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants