Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prod build is failing with Directive SelectableRow, Expected 0 arguments, but got 1. #10180

Closed
kewalpasad opened this issue Apr 29, 2021 · 4 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@kewalpasad
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => Search GitHub for a similar issue or PR before submitting
[ ] feature request => Please check if the request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit a support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
I have added the selectableRow directive to my p-table. It is behaving as expected but when I build it with --prod it is throwing Directive SelectableRow, Expected 0 arguments, but got 1. so I did some digging looks like the problem is something to do with the AOT compiler as pointed out here https://stackoverflow.com/questions/66161266/library-production-build-failed-on-angular-11-with-expected-0-arguments-but-go.

Expected behavior
should not through any error while building with --prod flag

  • Angular version: 5.X*
    Angular CLI: 9.1.5
    Node: 10.19.0
  • PrimeNG version: 5.X
    PrimeNG version11.3.1
  • Browser:
    Chrome

  • Language:
    TypeScript 3.8.3

  • Node (for AoT issues): node --version = 10.19.0

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Apr 30, 2021
@yigitfindikli yigitfindikli self-assigned this Apr 30, 2021
@yigitfindikli yigitfindikli added this to the 11.4.1 milestone Apr 30, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Apr 30, 2021
@ruchiagrawal2
Copy link

ruchiagrawal2 commented May 5, 2021

I am getting the same error in angular 10, prime ng 11.4.0 . How can I resolve this error by still keeping enableIvy=false. Thank You. Do I need to wait for 11.4.1 to fix this when using enableIvy=false ?

@kewalpasad
Copy link
Author

it should be fixed now the fix was added to the repo by @yigitfindikli

@ruchiagrawal2
Copy link

@kewalpasad Thanks. @yigitfindikli Do I need to wait for 11.4.1 to get this fix ? When is the expected release of 11.4.1 ? any work around ?

@yigitfindikli
Copy link
Contributor

@kewalpasad thanks for the report!
@ruchiagrawal2 V11.4.1 will be released next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants