Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputNumber on mobile works like textinput #10142

Closed
adriancoca opened this issue Apr 20, 2021 · 1 comment
Closed

InputNumber on mobile works like textinput #10142

adriancoca opened this issue Apr 20, 2021 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@adriancoca
Copy link

adriancoca commented Apr 20, 2021

I'm submitting a bug

[ x] bug report 


Current behavior
Chrome Android
When trying to write something in a InputNumber the full keyboard is open, also the validation that on desktop is working fine do not seem to apply on mobile.

Expected behavior
the input should have -> inputmode="decimal" (now i created a directive that add this attribute on input)
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode
In this way on mobile the number keyboard will be shown.

The same validation logic like on desktop should run when user is entering values in input.

Minimal reproduction of the problem with instructions

try to fill inputs in this page android chrome

https://primefaces.org/primeng/showcase/#/inputnumber

  • Angular version:
    11.1.2

  • PrimeNG version:
    11.3.2

  • Browser:
    Android Chrome

nr

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Apr 21, 2021
@mertsincan mertsincan self-assigned this Sep 6, 2021
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Sep 6, 2021
@mertsincan mertsincan added this to the 12.1.1 milestone Sep 6, 2021
@SRQCarlosAraujo
Copy link

SRQCarlosAraujo commented Apr 15, 2024

I was using inputNumber in my application and I came across a similar error even today. The mask works perfectly on the desktop, unlike on mobile, where the user can type periods and commas, breaking the model defined by the developer.
@yigitfindikli

WhatsApp Image 2024-04-15 at 17 06 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

4 participants