Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel does not always display dynamically added items #10051

Closed
szape89 opened this issue Mar 29, 2021 · 2 comments
Closed

Carousel does not always display dynamically added items #10051

szape89 opened this issue Mar 29, 2021 · 2 comments
Assignees
@yigitfindikli
Labels
LTS-FIXED-9.2.6 Fixed in PrimeNG LTS 9.2.6 LTS-FIXED-10.1.1 Fixed in PrimeNG LTS 10.1.1 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
11.3.2

Comments

@szape89
Copy link

szape89 commented Mar 29, 2021

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request

Plunkr Case (Bug Reports)
https://stackblitz.com/edit/primeng-carousel-bug

Current behavior
Carousel does not always display dynamically added items.

Expected behavior
Carousel should always display added items.

Minimal reproduction of the problem with instructions

  • Configure 3 items per page and 3 items to scroll.
  • Have 5 items in the carousel.
  • Scroll to the end to see updates.
  • Add new item to the carousel: 6th item is not displayed.
  • Add new item to the carousel: both 6th and 7th item are displayed.

Angular version: 11.x.x (tested: 11.0.9 and 11.2.0)

PrimeNG version: 11.x.x (tested: 11.2.3 and 11.3.0)

Browser: Chrome, Firefox
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Mar 29, 2021
@nishant203 nishant203 mentioned this issue Apr 3, 2021
Merged
@nishant203
Copy link
Contributor

Hi @yigitfindikli
The PR #10073 fixes the bug.

P.S. - This will be my first open source contribution if the PR gets accepted :)

@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Apr 5, 2021
@yigitfindikli yigitfindikli self-assigned this Apr 5, 2021
@yigitfindikli yigitfindikli added this to the 11.3.2 milestone Apr 5, 2021
@yigitfindikli
Copy link
Contributor

yigitfindikli commented Apr 5, 2021 •
edited
Loading

Hi @nishant203,

You're PR gonna be accepted :)

@yigitfindikli yigitfindikli added LTS-FIXED-10.1.1 Fixed in PrimeNG LTS 10.1.1 LTS-FIXED-9.2.6 Fixed in PrimeNG LTS 9.2.6 and removed LTS-PORTABLE labels Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
LTS-FIXED-9.2.6 Fixed in PrimeNG LTS 9.2.6 LTS-FIXED-10.1.1 Fixed in PrimeNG LTS 10.1.1 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
11.3.2
Development

No branches or pull requests
3 participants
@nishant203 @yigitfindikli @szape89