Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picklist dragdrop input can't disable drag and drop #10037

Closed
ramonvanbezouw opened this issue Mar 24, 2021 · 1 comment
Closed

Picklist dragdrop input can't disable drag and drop #10037

ramonvanbezouw opened this issue Mar 24, 2021 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ramonvanbezouw
Copy link
Contributor

Issue
Docs specify the dragdrop input for enabling / disabling drag and drop for the Picklist component:

dragdrop boolean false Whether to enable dragdrop based reordering.

This feature does not work.

Expected behavior:
Setting [dragdrop]="false" on <p-picklist> should disable drop behaviour for the items.

Actual behavior:
Drag and drop of items in <p-picklist> always works, regardless of the setting.

Minimal reproduction of the problem with instructions
In the showcase change [dragdrop]="true" to [dragdrop]="false", drag will still work.

Proposed fix: (PR: #10036)
The dragdrop Input is not being used by the component. Adding [cdkDropListDisabled]="!dragdrop" to the source and target cdkDropList, the dragdrop input works as expected.

Fix was tested in Windows Chromium 89, Windows Firefox 87, iOS Safari 14.

@yigitfindikli yigitfindikli added Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 24, 2021
@yigitfindikli yigitfindikli added this to the 11.3.2 milestone Mar 24, 2021
@yigitfindikli yigitfindikli self-assigned this Mar 24, 2021
@cm-noesis
Copy link

I was also looking for this. If the picklist is disabled, drag&drop is still allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants