Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump for release #93

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Bump for release #93

merged 1 commit into from
Mar 10, 2023

Conversation

cpiemontese
Copy link
Contributor

No description provided.

@cpiemontese cpiemontese requested a review from a team as a code owner March 9, 2023 13:24
@cpiemontese cpiemontese changed the title Bmp for release Bump for release Mar 9, 2023
@cpiemontese
Copy link
Contributor Author

Unsure about the version

@MaeIsBad
Copy link
Member

MaeIsBad commented Mar 9, 2023 •
edited
Loading

I think patch is fine. I don't think we consider telemetry attributes as being covered by semver

@cpiemontese
Copy link
Contributor Author

Agreed!

MaeIsBad
MaeIsBad approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@MaeIsBad MaeIsBad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to approve 🤦

@cpiemontese cpiemontese merged commit 3821490 into master Mar 10, 2023
@cpiemontese cpiemontese deleted the prepare-release branch March 10, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaeIsBad MaeIsBad MaeIsBad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpiemontese @MaeIsBad