Add requeue_on_reject configuration option #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cando
requested review from
neslinesli93,
squaini and
michelangelomo
and removed request for
neslinesli93
michelangelomo
approved these changes
Jul 11, 2022
larrywax
approved these changes
Jul 11, 2022
|
Thank you guys for your review. Do you need something else from my side in order to merge this PR? |
squaini
approved these changes
Jul 12, 2022
|
Hi @michelangelomo @larrywax, are we good to merge? |
|
Hi @edoardocostantinidev @cando, sorry for the delay 🙏 amqpx has been released with version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
requeue_on_rejectoption to allow aAmqpx.Gen.Consumerto skip the default requeue mechanism that is hard-coded right now in the library.If the option is not set or set to
true, the behaviour remains the same as today.If the option is set to
false:handle_message_rejectioncallback will be calledBasic.rejectwill be called withrequeue: falsePlease note that this PR should close issue #56.