[POM-76] test: 일 정산 조회 테스트 코드 작성 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeon-z
requested review from
choi5798,
juno-junho,
Juhongseok,
beomukim and
ddongpuri
juno-junho
approved these changes
Sep 21, 2023
| @@ -17,4 +18,18 @@ public record DailySettlementResponse( | |||
| int payOutAmount | |||
| ) { | |||
|
|
|||
| public DailySettlementResponse(Settlement settlement) { | |||
| this( | |||
| settlement.getPayOut().getPayOutDate(), | |||
There was a problem hiding this comment.
get.get이 좀 거슬리긴 하지만...
도메인에 대해서는 현지님이 더 잘 아시기에 별도의 이유가 있을거라 생각합니다.
There was a problem hiding this comment.
PayOut이 값 객체라 해당 방식으로 구현헀습니다..!
| .isInstanceOf(IllegalArgumentException.class); | ||
| } | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 구현 설명
일 정산 조회 테스트 코드 작성
👩💻 요구 사항과 구현 내용