Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POM-80] feat: 옵션 등록 기능 구현 #55

Merged
merged 19 commits into from
Sep 22, 2023
Merged

[POM-80] feat: 옵션 등록 기능 구현 #55

merged 19 commits into from
Sep 22, 2023

Conversation

juno-junho
Copy link
Collaborator

📌 설명

  • 개별적인 옵션을 등록하는 crud 기능 구현입니다.
  • Option 엔티티 생성시에는 반드시 OptionGroup이 설정되어 있어야 하기 때문에 optionGroup을 엔티티 생성시 설정해 주지 않으면 예외가 발생합니다.
    따라서 controller에서 optionGroup을 조회해온 뒤 온전한 option 엔티티를 생성해 저장합니다.

@juno-junho juno-junho self-assigned this Sep 21, 2023
Juhongseok
Juhongseok requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@Juhongseok Juhongseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인부탁드려요

hyeon-z
hyeon-z approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@hyeon-z hyeon-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/main/java/com/ray/pominowner/menu/controller/OptionController.java Outdated Show resolved Hide resolved
src/main/java/com/ray/pominowner/menu/controller/OptionController.java Outdated Show resolved Hide resolved
Juhongseok
Juhongseok approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@Juhongseok Juhongseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

choi5798
choi5798 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@choi5798 choi5798 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗝️

@juno-junho juno-junho merged commit ae09af0 into dev Sep 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juhongseok Juhongseok Juhongseok approved these changes

@hyeon-z hyeon-z hyeon-z approved these changes

@choi5798 choi5798 choi5798 approved these changes

@beomukim beomukim Awaiting requested review from beomukim

@ddongpuri ddongpuri Awaiting requested review from ddongpuri

Assignees

@juno-junho juno-junho

Labels
FEAT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juno-junho @choi5798 @hyeon-z @Juhongseok